Code review is an important aspect of code design and the review process. It is very effective in finding problems with the code that automated tools wouldn't be able to find. Developers also gain a lot of knowledge in seeing other peoples implementations and having their own work critiqued. We each had 2 branches of the command line interfaces for WattDepot to review. I reviewed the Ehiku and Ewalu branches of the WattDepot.
Ehiku branch:
The branch wasn't separated into a command and processor subpackage. This branch had all of the commands working except for the chart command. It wouldn't save to the specified filename and the result file wasn't a html file. There weren't any test cases. Overall a very good job.
Download Here
Ewalu branch:
Again, this branch wasn't separated into a command and processor subpackage. This branch had all of the commands working. All of the commands were located in a single class, Command.java. The test cases were mostly happy path tests. This team also did a very good job.
Download Here
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment